]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: Remove unnecessary check for groups 13314/head
authoranlan_cs <vic.lan@pica8.com>
Sun, 16 Apr 2023 05:41:40 +0000 (13:41 +0800)
committeranlan_cs <vic.lan@pica8.com>
Sun, 16 Apr 2023 05:52:35 +0000 (13:52 +0800)
The `NULL` check for newly created groups (`updgroup` and `subgroup`)
are unnecessary,  just remove them.

Signed-off-by: anlan_cs <vic.lan@pica8.com>
bgpd/bgp_updgrp.c

index 72dca9f702925c57022fe41a0d9786ac806a86fc..0b1e54916a7892e204010f878725f47a025cbbc6 100644 (file)
@@ -1961,15 +1961,8 @@ void update_group_adjust_peer(struct peer_af *paf)
        }
 
        updgrp = update_group_find(paf);
-       if (!updgrp) {
+       if (!updgrp)
                updgrp = update_group_create(paf);
-               if (!updgrp) {
-                       flog_err(EC_BGP_UPDGRP_CREATE,
-                                "couldn't create update group for peer %s",
-                                paf->peer->host);
-                       return;
-               }
-       }
 
        old_subgrp = paf->subgroup;
 
@@ -1992,11 +1985,8 @@ void update_group_adjust_peer(struct peer_af *paf)
        }
 
        subgrp = update_subgroup_find(updgrp, paf);
-       if (!subgrp) {
+       if (!subgrp)
                subgrp = update_subgroup_create(updgrp);
-               if (!subgrp)
-                       return;
-       }
 
        update_subgroup_add_peer(subgrp, paf, 1);
        if (BGP_DEBUG(update_groups, UPDATE_GROUPS))