]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: fix printfrr_bp for non initialized peers
authorLouis Scalbert <louis.scalbert@6wind.com>
Wed, 2 Oct 2024 12:38:15 +0000 (14:38 +0200)
committerton31337 <3352707+ton31337@users.noreply.github.com>
Thu, 3 Oct 2024 06:38:41 +0000 (06:38 +0000)
Fix printfrr_bp for non initialized peers. For example:

> Sep 26 17:56:44 r1 bgpd[26295]: [GJPH1-W8PZV] Resetting peer (null)(Unknown) due to change in addpath config

Is now:

> Oct 02 14:00:59 r1 bgpd[12795]: [MNE5N-K0G4Z] Resetting peer 2.2.2.2 due to change in addpath config

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
(cherry picked from commit b56cfc6c808d330a85a06421c7fc5f5f9066938f)

bgpd/bgpd.c

index e7ff73e6e2caf309fc116877541c6899e0d6b70f..470b33ca3b03857319176b80c87d63eeca09fefb 100644 (file)
@@ -8677,6 +8677,12 @@ static ssize_t printfrr_bp(struct fbuf *buf, struct printfrr_eargs *ea,
        if (!peer)
                return bputs(buf, "(null)");
 
+       if (!peer->host) {
+               if (peer->conf_if)
+                       return bprintfrr(buf, "%s", peer->conf_if);
+               return bprintfrr(buf, "%pSU", &peer->connection->su);
+       }
+
        return bprintfrr(buf, "%s(%s)", peer->host,
                         peer->hostname ? peer->hostname : "Unknown");
 }