ospf6d: External LSAs reoriginates on every redistribute CLI

Problem Statement:
==================
Everytime redistribute CLI is executed, external LSAs are
re-originated. When there is no change in the CLI parameters
the LSAs should not get re-originated.

Fix:
=================
Check if the CLI params are same, do not re-originate the LSA.

Fixes: #9445
Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>

diff --git a/ospf6d/ospf6_asbr.c b/ospf6d/ospf6_asbr.c
index 5cf879b8cf7b3857263e650f2e94c68e5df1453b..2b11d89a31b77b34cbdcb6512dab2002463bbd91 100644 (file)
--- a/ospf6d/ospf6_asbr.c
+++ b/ospf6d/ospf6_asbr.c
@@ -1643,10 +1643,15 @@ DEFUN (ospf6_redistribute,
                return CMD_WARNING_CONFIG_FAILED;
 
        red = ospf6_redist_lookup(ospf6, type, 0);
-       if (!red)
+       if (!red) {
                ospf6_redist_add(ospf6, type, 0);
-       else
+       } else {
+               /* To check, if user is providing same config */
+               if (ROUTEMAP_NAME(red) == NULL)
+                       return CMD_SUCCESS;
+
                ospf6_asbr_redistribute_unset(ospf6, red, type);
+       }
 
        ospf6_asbr_redistribute_set(ospf6, type);
 
@@ -1674,10 +1679,16 @@ DEFUN (ospf6_redistribute_routemap,
                return CMD_WARNING_CONFIG_FAILED;
 
        red = ospf6_redist_lookup(ospf6, type, 0);
-       if (!red)
+       if (!red) {
                red = ospf6_redist_add(ospf6, type, 0);
-       else
+       } else {
+               /* To check, if user is providing same route map */
+               if ((ROUTEMAP_NAME(red) != NULL)
+                   && (strcmp(argv[idx_word]->arg, ROUTEMAP_NAME(red)) == 0))
+                       return CMD_SUCCESS;
+
                ospf6_asbr_redistribute_unset(ospf6, red, type);
+       }
 
        ospf6_asbr_routemap_set(red, argv[idx_word]->arg);
        ospf6_asbr_redistribute_set(ospf6, type);