]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: fix bgp orf prefix-list json prefix
authorLouis Scalbert <louis.scalbert@6wind.com>
Thu, 9 Jan 2025 17:24:39 +0000 (18:24 +0100)
committerMergify <37929162+mergify[bot]@users.noreply.github.com>
Thu, 9 Jan 2025 20:58:58 +0000 (20:58 +0000)
0x<address>FX was displayed instead of the prefix.

Fixes: b219dda129 ("lib: Convert usage of strings to %pFX and %pRN")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
(cherry picked from commit b7e843d7e8afe57d3815dbb44e30307654e73711)

lib/plist.c

index 3fc8e2a1ffac2bf08692c4efdf8c16345fd68a85..40b3c8e498019d74702e4ba27e47be4f5d7d5a18 100644 (file)
@@ -1544,11 +1544,6 @@ int prefix_bgp_show_prefix_list(struct vty *vty, afi_t afi, char *name,
                                       plist->name);
 
                for (pentry = plist->head; pentry; pentry = pentry->next) {
-                       struct prefix *p = &pentry->prefix;
-                       char buf_a[BUFSIZ];
-
-                       snprintf(buf_a, sizeof(buf_a), "%pFX", p);
-
                        json_object_int_add(json_list, "seq", pentry->seq);
                        json_object_string_add(json_list, "seqPrefixListType",
                                               prefix_list_type_str(pentry));
@@ -1560,7 +1555,7 @@ int prefix_bgp_show_prefix_list(struct vty *vty, afi_t afi, char *name,
                                json_object_int_add(json_list, "le",
                                                    pentry->le);
 
-                       json_object_object_add(json_prefix, buf_a, json_list);
+                       json_object_object_addf(json_prefix, json_list, "%pFX", &pentry->prefix);
                }
                if (afi == AFI_IP)
                        json_object_object_add(json, "ipPrefixList",