]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: Use sizeof() in bgp_dump_attr()
authorDonatas Abraitis <donatas.abraitis@gmail.com>
Tue, 18 Aug 2020 18:43:07 +0000 (21:43 +0300)
committerDonatas Abraitis <donatas.abraitis@gmail.com>
Wed, 19 Aug 2020 13:02:05 +0000 (16:02 +0300)
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd/bgp_evpn.c
bgpd/bgp_packet.c
bgpd/bgp_updgrp_packet.c

index 79a8fae530a005e74d562543af73627c2dbba19f..da5d0ccdb76fd498192c735bd0f6abfc12275398 100644 (file)
@@ -3163,7 +3163,7 @@ static int bgp_evpn_route_rmac_self_check(struct bgp *bgp_vrf,
                        char buf1[PREFIX_STRLEN];
                        char attr_str[BUFSIZ] = {0};
 
-                       bgp_dump_attr(pi->attr, attr_str, BUFSIZ);
+                       bgp_dump_attr(pi->attr, attr_str, sizeof(attr_str));
 
                        zlog_debug("%s: bgp %u prefix %s with attr %s - DENIED due to self mac",
                                __func__, bgp_vrf->vrf_id,
@@ -5569,7 +5569,7 @@ int bgp_filter_evpn_routes_upon_martian_nh_change(struct bgp *bgp)
                                        char pbuf[PREFIX_STRLEN];
 
                                        bgp_dump_attr(pi->attr, attr_str,
-                                                     BUFSIZ);
+                                                     sizeof(attr_str));
 
                                        if (bgp_debug_update(pi->peer, &rn->p,
                                                             NULL, 1))
index b7e9af002b40294084bd6f56627a928a38034b4e..53c75dd1c154720b9bee32a0dc1b117bc12976b5 100644 (file)
@@ -1526,7 +1526,8 @@ static int bgp_update_receive(struct peer *peer, bgp_size_t size)
        if (attr_parse_ret == BGP_ATTR_PARSE_WITHDRAW
            || BGP_DEBUG(update, UPDATE_IN)
            || BGP_DEBUG(update, UPDATE_PREFIX)) {
-               ret = bgp_dump_attr(&attr, peer->rcvd_attr_str, BUFSIZ);
+               ret = bgp_dump_attr(&attr, peer->rcvd_attr_str,
+                                   sizeof(peer->rcvd_attr_str));
 
                peer->stat_upd_7606++;
 
index 9329c8d8922af4978a693f44b3397318098cd42b..6ddf70e6b48601ffb37b5bec77f5271702fb4e5a 100644 (file)
@@ -818,7 +818,7 @@ struct bpacket *subgroup_update_packet(struct update_subgroup *subgrp)
                                memset(send_attr_str, 0, BUFSIZ);
                                send_attr_printed = 0;
                                bgp_dump_attr(adv->baa->attr, send_attr_str,
-                                             BUFSIZ);
+                                             sizeof(send_attr_str));
                        }
                }
 
@@ -1128,7 +1128,7 @@ void subgroup_default_update_packet(struct update_subgroup *subgrp,
 
                attrstr[0] = '\0';
 
-               bgp_dump_attr(attr, attrstr, BUFSIZ);
+               bgp_dump_attr(attr, attrstr, sizeof(attrstr));
 
                if (addpath_encode)
                        snprintf(tx_id_buf, sizeof(tx_id_buf),