]> git.puffer.fish Git - mirror/frr.git/commit
ospfd: fix another DR election issue during graceful restart 9813/head
authorRenato Westphal <renato@opensourcerouting.org>
Tue, 12 Oct 2021 19:08:23 +0000 (16:08 -0300)
committerRenato Westphal <renato@opensourcerouting.org>
Tue, 12 Oct 2021 20:33:32 +0000 (17:33 -0300)
commit3ebf9d34161833d5ab102d3d4f9107b1d8c01481
tree163352f5eb89a7b79caac349560fffaa1bee4d52
parenteedc80c1f59c060d0f313dee9910f32f99c606c3
ospfd: fix another DR election issue during graceful restart

Commit 3551ee9e90304 introduced a regression that causes GR to fail
under certain circumstances. In short, while ISM events should
be ignored while acting as a helper for a restarting router, the
DR/BDR fields of the neighbor structure should still be updated
while processing a Hello packet. If that isn't done, it can cause
the helper to elect the wrong DR while exiting from the helper mode,
leading to a situation where there are two DRs for the same network
segment (and a failed GR by consequence). Fix this.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
ospfd/ospf_packet.c