]> git.puffer.fish Git - mirror/frr.git/commit
isisd: Fix handling of neighbor circuit id in three way handshake 5089/head
authorChristian Franke <chris@opensourcerouting.org>
Mon, 30 Sep 2019 23:53:44 +0000 (01:53 +0200)
committerChristian Franke <chris@opensourcerouting.org>
Tue, 1 Oct 2019 13:55:42 +0000 (15:55 +0200)
commit2028040307fc3511b4fb715e454f10f895dcfd35
treef0cf344866df9a7d76b88bfb7a0b0a72dd3f06b5
parentba0d195d59cc3de3ad9598574d8f1e4df236f37e
isisd: Fix handling of neighbor circuit id in three way handshake

RFC 5303 states:

      If the system ID and Extended Local Circuit ID of the neighboring
      system are known (in adjacency three-way state Initializing or
      Up), the neighbor's system ID SHALL be reported in the Neighbor
      System ID field, and the neighbor's Extended Local Circuit ID
      SHALL be reported in the Neighbor Extended Local Circuit ID field.

There is nothing written about only setting the Extended circuit ID of the
adjacency only when we bring the three-way adjacency up.

In fact, we should always update it, to avoid the problem described in #4783.

Fixes: #4783
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
isisd/isis_pdu.c