]> git.puffer.fish Git - mirror/frr.git/commit
bgpd: do not send keepalives when KA timer is 0 4986/head
authorQuentin Young <qlyoung@cumulusnetworks.com>
Mon, 16 Sep 2019 15:33:49 +0000 (15:33 +0000)
committerQuentin Young <qlyoung@cumulusnetworks.com>
Mon, 16 Sep 2019 16:18:07 +0000 (16:18 +0000)
commitd8e2b28bd8e4a755766f6154f2d8c68ec77fa005
treeac5cd8dcce2fc1c14a136eda85aa2e8c653593a7
parent4de6689dc7add729d99007d88f1e40df2cc43f17
bgpd: do not send keepalives when KA timer is 0

RFC4271 specifies behavior when the hold timer is sent to zero - we
should not send keepalives or run a hold timer. But FRR, and other
vendors, allow the keepalive timer to be set to zero with a nonzero hold
timer. In this case we were sending keepalives constantly and maxing out
a pthread to do so. Instead behave similarly to other vendors and do not
send keepalives.

Unsure what the utility of this is, but blasting keepalives is
definitely the wrong thing to do.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
bgpd/bgp_keepalives.c