]> git.puffer.fish Git - mirror/frr.git/commit
bgpd: Finalize group-overrides for peer/AF attrs 2445/head
authorPascal Mathis <mail@pascalmathis.com>
Thu, 14 Jun 2018 16:03:33 +0000 (18:03 +0200)
committerPascal Mathis <mail@pascalmathis.com>
Thu, 14 Jun 2018 16:55:33 +0000 (18:55 +0200)
commit4c3911425c6fbfdd5014fcef3fc37ced69a7c408
tree0158504ef86417a443ff9e3bbb7349318503f4ef
parenta14810f43f6a7970468eb2568385ca75c4708e4d
bgpd: Finalize group-overrides for peer/AF attrs

This commit finalizes the previous commits which introduced a generic
approach for making all BGP peer and address-family attributes
overrideable by keeping track of the configuration origin in separate
internal structures.

First of all, the test suite was greatly extended to also check the
internal data structures of peer/AF attributes, so that inheritance for
internal values like 'peer->weight' is also being checked in all cases.

This revealed some smaller issues in the implementation, which were also
fixed in this commit. The test suite now fully passes and covers all the
usual situations that should normally occur.

Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
bgpd/bgpd.c
tests/bgpd/test_peer_attr.c