]> git.puffer.fish Git - mirror/frr.git/commit
mgmtd: normalize argument order to copy(dst, src) 18601/head
authorChristian Hopps <chopps@labn.net>
Tue, 8 Apr 2025 05:55:03 +0000 (05:55 +0000)
committerChristian Hopps <chopps@labn.net>
Wed, 9 Apr 2025 10:14:58 +0000 (10:14 +0000)
commit59d2368b0f055f28aeda8f6080d686acfa35c20b
treec4112f18aa261081b6c3d59ce705b43c47c1fa97
parentb12b4c28b4c4a76cbc906b703ee5a694a082ab74
mgmtd: normalize argument order to copy(dst, src)

Having just completed a code audit during RCA, the fact that we have 2
different argument orders for the related datastore copying functions
was unnecessary and super confusing.

Fix this code-maintenance/comprehension mistake and move the newer mgmtd
copy routines to use the same arg order as the pre-existing underlying
northbound copy functions (i.e., use `copy(dst, src)`)

Signed-off-by: Christian Hopps <chopps@labn.net>
mgmtd/mgmt_ds.c
mgmtd/mgmt_ds.h
mgmtd/mgmt_txn.c