]> git.puffer.fish Git - mirror/frr.git/commit
ospf6d: fix infinite loop when adding ASBR route 12389/head
authorRenato Westphal <renato@opensourcerouting.org>
Thu, 24 Nov 2022 01:14:51 +0000 (22:14 -0300)
committerRenato Westphal <renato@opensourcerouting.org>
Thu, 24 Nov 2022 16:08:26 +0000 (13:08 -0300)
commit4dfe15200ab1a84a8d77fcbc33085c373d556eae
treeebf8541d3699393368dc2b9dedb714fe3d9bdd72
parentd15c84fa223bb32500912af1d05c8a701a643e15
ospf6d: fix infinite loop when adding ASBR route

Commit 8f359e1593c414322 removed a check that prevented the same route
from being added twice. In certain topologies, that change resulted in
the following infinite loop when adding an ASBR route:

ospf6_route_add
 ospf6_top_brouter_hook_add
  ospf6_abr_examin_brouter
   ospf6_abr_examin_summary
    ospf6_route_add
     (repeat until stack overflow)

Revert the offending commit and update `ospf6_route_is_identical()` to
not do comparison using `memcmp()`.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
ospf6d/ospf6_route.c
ospf6d/ospf6_route.h