]> git.puffer.fish Git - mirror/frr.git/commit
bgpd: Fix crash when disabling dampening (BZ#687)
authorJorge Boncompte [DTI2] <jorge@dti2.net>
Fri, 13 Apr 2012 11:46:09 +0000 (13:46 +0200)
committerDavid Lamparter <equinox@diac24.net>
Mon, 16 Apr 2012 16:37:17 +0000 (18:37 +0200)
commitfa4094ac49b4cc23589f5c5b7e608c4b4ee6ca04
tree6ee1470a3db1d3e09e455a34a41b6b5db4296847
parent7939e016b3d4ecd2f5b8ad708b69607e05a084a6
bgpd: Fix crash when disabling dampening (BZ#687)

    Vladimir Podobaev reported that the following commands crashed the
daemon.

router bgp 123
 bgp dampening
 no bgp dampening 1 2 3 4
 no bgp dampening

    The problem was that bgp_damp_info_clean() tried to dereference the
already freed reuse_list array in the second call to "no bgp dampening".

    Fixed by checking in bgp_damp_disable() that the dampening it's
enabled before doing the cleanup.

Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
bgpd/bgp_damp.c