]> git.puffer.fish Git - mirror/frr.git/commit
bgpd: don't try to reconcile AS4_PATH with NULL
authorDavid Lamparter <equinox@opensourcerouting.org>
Sun, 20 Jan 2013 17:29:28 +0000 (18:29 +0100)
committerDavid Lamparter <equinox@opensourcerouting.org>
Fri, 1 Feb 2013 16:55:04 +0000 (17:55 +0100)
commitf47e5a18b5beb00d6b5b94965e305dadb5aa5bad
treec870b37cdba8e36effae527faf6c266847ad2621
parent955be06f8a647d1149d5547e1265fb66f55a9161
bgpd: don't try to reconcile AS4_PATH with NULL

bgp_attr_munge_as4_attrs would previously try to reintegrate an AS4_PATH
with a NULL AS_PATH, leading to a rather nasty SEGV.  Let's go by
RFC6793 and treat missing AS_PATH as 0-length AS_PATH, which in turn
means discarding the AS4_PATH.

[NB: we don't actually stick to the actual rule, which is discarding
AS4_PATH if it's longer than AS_PATH; indeed we should probably fix that
too]

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
bgpd/bgp_attr.c