]> git.puffer.fish Git - mirror/frr.git/commit
isisd: Fix memory leaks when the transition of neighbor state from non-UP to DOWN 17298/head
authorzhou-run <166502045+zhou-run@users.noreply.github.com>
Tue, 9 Apr 2024 13:04:39 +0000 (21:04 +0800)
committerMergify <37929162+mergify[bot]@users.noreply.github.com>
Tue, 29 Oct 2024 15:19:54 +0000 (15:19 +0000)
commitf145648d0a9b92cff8ac99429fcc90a1527317b9
tree3b68e5b5c2fc0a43ca4efc2efa056cbb72c561dc
parentb14878822e8d3cba1a4801a36df2e9303e5598b0
isisd: Fix memory leaks when the transition of neighbor state from non-UP to DOWN

When receiving a hello packet, if the neighbor state transitions directly from a non-ISIS_ADJ_UP state (such as ISIS_ADJ_INITIALIZING) to ISIS_ADJ_DOWN state, the neighbor entry cannot be deleted. If the neighbor is removed or the neighbor's System ID changes, it may result in memory leakage in the neighbor entry.

Test Scenario:
LAN link between Router A and Router B is established. Router A does not configure neighbor authentication, while Router B is configured with neighbor authentication. When the neighbor entry on Router B ages out, the neighbor state on Router A transitions to INIT. If Router B is then removed, the neighbor state on Router A transitions to DOWN and persists.

Signed-off-by: zhou-run <166502045+zhou-run@users.noreply.github.com>
fix frrbot styling issues found.

fix frrbot styling issues found.

Signed-off-by: zhou-run <166502045+zhou-run@users.noreply.github.com>
(cherry picked from commit 5009f7539ad6bf496158499917dcf3f7ab760753)
isisd/isis_adjacency.c