]> git.puffer.fish Git - mirror/frr.git/commit
bfdd: Prevent uninited use of data 3968/head
authorDonald Sharp <sharpd@cumulusnetworks.com>
Sun, 17 Mar 2019 01:25:59 +0000 (21:25 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 20 Mar 2019 14:32:58 +0000 (10:32 -0400)
commited74032b7fba70bde4bfc118690b38e49d057c69
tree0e99573b71908e1ec3b6c73671f482505cc5ff5f
parentc3eb25c3fead79d3719f98ecb2a0eb9068fc2a89
bfdd: Prevent uninited use of data

Running valgrind w/ bfdd and shut/no shuting interfaces
can result in this valgrind issue:

==20279== Conditional jump or move depends on uninitialised value(s)
==20279==    at 0x115848: bfdd_sessions_enable_address (ptm_adapter.c:644)
==20279==    by 0x115848: bfdd_interface_address_update (ptm_adapter.c:674)
==20279==    by 0x48D8CAB: zclient_read (zclient.c:2698)
==20279==    by 0x48CCEE3: thread_call (thread.c:1603)
==20279==    by 0x48A84EF: frr_run (libfrr.c:1011)
==20279==    by 0x10DAC3: main (bfdd.c:236)
==20279==

When creating the bso data structure set the bso_isaddress to false
as a default value.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bfdd/bfd.c