]> git.puffer.fish Git - matthieu/frr.git/commit
isisd: address Coverity warnings
authorDavid Lamparter <equinox@opensourcerouting.org>
Tue, 27 Nov 2012 01:10:30 +0000 (01:10 +0000)
committerDavid Lamparter <equinox@opensourcerouting.org>
Wed, 12 Dec 2012 14:38:08 +0000 (15:38 +0100)
commite8aca32f312cbef1cb0b0dd9e87b7e59dc9fa251
treef1dd65169e4cbc6bb7da2d76466b049703587123
parent318c8040abc1b8a737c941382e8aca82e546da09
isisd: address Coverity warnings

this fixes a bunch of issues found by Coverity SCAN and flagged as
"high" impact -- although, they're all rather minute issues.

* isisd/isis_adjacency.c: one superfluous check, one possible NULL deref
* isisd/isis_circuit.c: two prefix memory leaks
* isisd/isis_csm.c: one missing break
* isisd/isis_lsp.c: one possible NULL deref
* isisd/isis_pfpacket.c: one error-case fd leak
* isisd/isis_route.c: one isis_route_info memory leak
* isisd/isis_routemap.c: one... fnord
* isisd/isis_tlv.c: one infinite loop

Reported-by: Coverity SCAN
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
isisd/isis_adjacency.c
isisd/isis_circuit.c
isisd/isis_csm.c
isisd/isis_lsp.c
isisd/isis_pfpacket.c
isisd/isis_route.c
isisd/isis_routemap.c
isisd/isis_spf.c
isisd/isis_tlv.c