]> git.puffer.fish Git - mirror/frr.git/commit
projects / mirror / frr.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8aca554) | patch
bgpd: don't reuse nexthop variable in loop/switch
authorDavid Lamparter <equinox@opensourcerouting.org>
Wed, 22 Jan 2025 10:13:21 +0000 (11:13 +0100)
committerDavid Lamparter <equinox@opensourcerouting.org>
Tue, 11 Feb 2025 08:49:33 +0000 (09:49 +0100)
commite3474219fb3b84695f744ffb3509c981c8010aa5
tree543a4bb77d543cea710fe269277cd56f7c1f67b2tree | snapshot
parent8aca554935c374e909a44af060f84346942214efcommit | diff
bgpd: don't reuse nexthop variable in loop/switch

While the loop is currently exited in all cases after using nexthop, it
is a footgun to have "nh" around to be reused in another iteration of
the loop.  This would leave nexthop with partial data from the previous
use.  Make it local where needed instead.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
(cherry picked from commit ce7f5b21221f0b3557d1f4a40793230d8bc4cf02)
bgpd/bgp_pbr.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.