]> git.puffer.fish Git - matthieu/frr.git/commit
Revert "staticd: Accept full blackhole typed keywords for ip_route_cmd"
authorIgor Ryzhov <iryzhov@nfware.com>
Tue, 30 Jan 2024 20:51:46 +0000 (22:51 +0200)
committerIgor Ryzhov <iryzhov@nfware.com>
Thu, 1 Feb 2024 22:25:15 +0000 (00:25 +0200)
commitd205208f57855a219e9c72b8a24976af3eb34bcd
tree8c9197af322ce362db4de0f1985d0b50619692f6
parent9d8fd14b56a7c0a35d761c323084083b957ecb86
Revert "staticd: Accept full blackhole typed keywords for ip_route_cmd"

This reverts commit 76b2bc97e73874d882d5cf021972cfca84656cef.

This change is wrong for several reasons:
- it is backwards incompatible - previously it was always possible to
  create blackhole/reject routes using shortened versions of the words
  and it suddenly became impossible if there's an interface in the
  system with the same name
- it uses operational data for validation which is prohibited
- it doesn't really solve the problem with inability to create routes
  using interface names like `bla` or `rej`
staticd/static_nb_config.c
staticd/static_vty.c