]> git.puffer.fish Git - matthieu/frr.git/commit
bgpd: do not send keepalives when KA timer is 0
authorQuentin Young <qlyoung@cumulusnetworks.com>
Mon, 16 Sep 2019 15:33:49 +0000 (15:33 +0000)
committerQuentin Young <qlyoung@cumulusnetworks.com>
Mon, 16 Sep 2019 16:15:07 +0000 (16:15 +0000)
commitbfc18a0205a7658a489add497600edbc8c503fb1
tree34e68b96ed4dfd3d30e9586c2670cacb752f47ad
parent8e0bab8a1e65b2c20562362ece350cc3204928d1
bgpd: do not send keepalives when KA timer is 0

RFC4271 specifies behavior when the hold timer is sent to zero - we
should not send keepalives or run a hold timer. But FRR, and other
vendors, allow the keepalive timer to be set to zero with a nonzero hold
timer. In this case we were sending keepalives constantly and maxing out
a pthread to do so. Instead behave similarly to other vendors and do not
send keepalives.

Unsure what the utility of this is, but blasting keepalives is
definitely the wrong thing to do.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
bgpd/bgp_keepalives.c