]> git.puffer.fish Git - matthieu/frr.git/commit
pimd: vrf may be NULL from pim_cmd_lookup_vrf
authorDonald Sharp <sharpd@nvidia.com>
Mon, 15 Aug 2022 15:43:27 +0000 (11:43 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Mon, 15 Aug 2022 19:45:05 +0000 (15:45 -0400)
commitbddd6bb95ef6eb521e2d3dbb70b368b6430f0552
tree7014048e16b597d3de8b1ee83d0a81063f09da9d
parente89de028950e9f6f4bd98a019e6bfa6dfd7b37c3
pimd: vrf may be NULL from pim_cmd_lookup_vrf

The call into pim_cmd_lookup_vrf may be NULL
and dereferencing it before ensuring that the
vrf pointer is non-NULL is a good way to crash.

A crash can be initiated in pim:

eva# show ip msdp vrf NOEXIST mesh-group
vtysh: error reading from pimd: Permission denied (13)Warning: closing connection to pimd because of an I/O error!
eva# 2022/08/15 11:47:38 [PHJDC-499N2][EC 100663314] STARVATION: task vtysh_rl_read (560b77f76de6) ran for 16777ms (cpu time 0ms)

eva#

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
pimd/pim_cmd.c