]> git.puffer.fish Git - matthieu/frr.git/commit
nhrpd: add cisco-authentication password support
authorDave LeRoy <dleroy@labn.net>
Wed, 5 Jun 2024 19:10:11 +0000 (12:10 -0700)
committerDave LeRoy <dleroy@labn.net>
Mon, 10 Jun 2024 23:39:21 +0000 (16:39 -0700)
commitb5540d326b82ca92ed88f9082fe0ed2433b09c27
tree3e82b5a8df280c7724bda5d3725b2fd4d5f9c1be
parent51f070028692260ea19b5ef0f489c56de5683bbc
nhrpd: add cisco-authentication password support

Taking over this development from https://github.com/FRRouting/frr/pull/14788

This commit addresses 4 issues found in the previous PR

1) FRR would accept messages from a spoke without authentication when FRR NHRP had auth configured.
2) The error indication was not being sent in network byte order
3) The debug print in nhrp_connection_authorized was not correctly printing the received password
4) The addresses portion of the mandatory part of the error indication was invalid on the wire (confirmed in wireshark)

Signed-off-by: Dave LeRoy <dleroy@labn.net>
Co-authored-by: Volodymyr Huti <volodymyr.huti@gmail.com>
doc/user/nhrpd.rst
nhrpd/nhrp_interface.c
nhrpd/nhrp_peer.c
nhrpd/nhrp_vty.c
tests/topotests/nhrp_topo/r1/nhrpd.conf
tests/topotests/nhrp_topo/r2/nhrpd.conf
tests/topotests/nhrp_topo/test_nhrp_topo.py