]> git.puffer.fish Git - matthieu/frr.git/commit
BGP: Check in multipath comparison before invoking sockunion_cmp
authorvivek <vivek@cumulusnetworks.com>
Sun, 13 Mar 2016 06:03:10 +0000 (06:03 +0000)
committervivek <vivek@cumulusnetworks.com>
Sun, 13 Mar 2016 06:03:10 +0000 (06:03 +0000)
commita3cb01d89c5c741b4fa3a0f4f46264eafa0184cf
tree23d2ffdb29e306105773c56638dd7482be1160ed
parente99789d89d018d59ffd1029a2f32dd49c129859c
BGP: Check in multipath comparison before invoking sockunion_cmp

During route selection for Multipath routes, when multiple peers are
flapping, it is possible that the old (former) multipath list of routes
for a destination may include routes from peers which are no longer in
Established state. When the new multipath list is compared against the
old list to identify changes, additional checks are needed to avoid
comparing connection addresses if the peer is not in Established state.
This patch introduces those checks.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Reviewed-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by: Don Slice <dslice@cumulusnetworks.com>
Ticket: CM-9671
Reviewed By: CCR-4277
Testing Done: Manual (problem could not be replicated to verify)
bgpd/bgp_mpath.c