]> git.puffer.fish Git - matthieu/frr.git/commit
lib: remove SAFI_RESERVED_4 and SAFI_RESERVED_5
authorRenato Westphal <renato@opensourcerouting.org>
Tue, 1 Aug 2017 00:09:01 +0000 (21:09 -0300)
committerRenato Westphal <renato@opensourcerouting.org>
Tue, 1 Aug 2017 02:38:38 +0000 (23:38 -0300)
commita08ca0a7e101cbc44fc9300520bd0ab6a2c9b784
treefc7a96bba33abeb7fb0f249837931efa05e0b8c1
parent84d5286a9f0e66a6f8264a33818ec173db5ceee7
lib: remove SAFI_RESERVED_4 and SAFI_RESERVED_5

SAFI values have been a major source of confusion over the last few
years. That's because each SAFI needs to be represented in two different
ways:
* IANA's value used to send/receive packets over the network;
* Internal value used for array indexing.

In the second case, defining reserved values makes no sense because we
don't want to index SAFIs that simply don't exist. The sole purpose of
the internal SAFI values is to remove the gaps we have among the IANA
values, which would represent wasted memory in C arrays. With that said,
remove these reserved SAFIs to avoid further confusion in the future.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
bgpd/bgp_fsm.c
bgpd/bgp_vty.c
bgpd/bgpd.c
lib/zebra.h