]> git.puffer.fish Git - matthieu/frr.git/commit
ospfd: Prevent use after free( and crash of ospf ) when no router ospf
authorDonald Sharp <sharpd@nvidia.com>
Wed, 30 Aug 2023 14:33:29 +0000 (10:33 -0400)
committerDonatas Abraitis <donatas@opensourcerouting.org>
Thu, 31 Aug 2023 08:05:07 +0000 (11:05 +0300)
commit98b8d08ca9c443fee79ab3b7563f69d2ae322354
tree0bd94c21a24a972dfd8b9dab59129fc7f3811d27
parent9d1ee3ade337cc195deaea76bda5b3e297df0c04
ospfd: Prevent use after free( and crash of ospf ) when no router ospf

Consider this config:

router ospf
  redistribute kernel

Then you issue:

no router ospf

ospf will crash with a use after free.

The problem is that the event's associated with the
ospf pointer were shut off then the ospf_external_delete
was called which rescheduled the event.  Let's just move
event deletion to the end of the no router ospf.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
ospfd/ospfd.c