ospfd: Fix conflict router-id, memory leaks

ospfd: Fix conflict router-id, memory leaks

Remove assert in path of router_id_update:
Upon configuring same router-id as neighbor's
assert would cause a crash. Log a warning message
and neighborship would not come up.

Address memory leaks

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>