]> git.puffer.fish Git - matthieu/frr.git/commit
isisd: Fix CID 1568129 (Null pointer dereference)
authorCarmine Scarpitta <cscarpit@cisco.com>
Fri, 15 Sep 2023 10:13:45 +0000 (12:13 +0200)
committerCarmine Scarpitta <cscarpit@cisco.com>
Fri, 15 Sep 2023 10:39:45 +0000 (12:39 +0200)
commit95eadb506816ed6b1bffdf8f0b7dfc7a8f16c3fb
treea7c95e1eb3719487c281051ba88818efb5342ea1
parent75dbd45c5570c088dc0e2cf83e1b22b0ec0a30b3
isisd: Fix CID 1568129 (Null pointer dereference)

Fix this coverity issue:

*** CID 1568129:  Null pointer dereferences  (REVERSE_INULL)
/isisd/isis_tlvs.c: 2813 in unpack_item_srv6_end_sid()
2807                    sid->subsubtlvs = NULL;
2808            }
2809
2810            append_item(&subtlvs->srv6_end_sids, (struct isis_item *)sid);
2811            return 0;
2812     out:
>>>     CID 1568129:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "sid" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
2813            if (sid)
2814                    free_item_srv6_end_sid((struct isis_item *)sid);
2815            return 1;
2816     }
2817
2818     /* Functions related to TLVs 1 Area Addresses */

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
isisd/isis_tlvs.c