]> git.puffer.fish Git - matthieu/frr.git/commit
ospfd: Do not fall back to intervening router.
authorJoakim Tjernlund <Joakim.Tjernlund@transmode.se>
Sat, 7 Jul 2012 15:06:14 +0000 (17:06 +0200)
committerDavid Lamparter <equinox@opensourcerouting.org>
Wed, 25 Jul 2012 16:07:45 +0000 (18:07 +0200)
commit9289c6ff55cd96c943d23e43fc9e5f987aa965ed
treeb971fa4b0ce15e02abd27a62548d53371e4cc0b2
parentba281d3d04053b7c59ecdfdbea91a62c09e9f8a4
ospfd: Do not fall back to intervening router.

The patch in bug 330 did two things. It add a return value
whether ospf_nexthop_calculation() failed or not and also
moved the return stmt for 16.1.1 para 5 so now SPF
will fallback to the intervening router when no back links are found
by 16.1.1 para 5. This is wrong and can potentially create black holes
or routing loops according to Dave Katz and Acee Lindem at ospf@ietf.org

Even if the current code could be proved to be harmless in all cases,
it adds substantial extra processing and memory allocations.

Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
ospfd/ospf_spf.c