]> git.puffer.fish Git - matthieu/frr.git/commit
isisd: fix update link params after circuit is up
authorLouis Scalbert <louis.scalbert@6wind.com>
Tue, 27 Aug 2024 16:22:27 +0000 (18:22 +0200)
committerMergify <37929162+mergify[bot]@users.noreply.github.com>
Tue, 3 Sep 2024 14:57:05 +0000 (14:57 +0000)
commit8fb29a38ae0a812f5737fd9b79845da23d5d0715
tree8945cb4abc079c8d1126aed5045f4bccd55f092b
parentee98186b60e08c4c2abaaeefb55c7a5731fbb608
isisd: fix update link params after circuit is up

If the link-params are set when the circuit not yet up, the link-params
are never updated.

isis_link_params_update() is called from isis_circuit_up() but returns
immediately because circuit->state != C_STATE_UP. circuit->state is
updated in isis_csm_state_change after isis_circuit_up().

> struct isis_circuit *isis_csm_state_change(enum isis_circuit_event event,
>     struct isis_circuit *circuit,
>     void *arg)
> {
> [...]
>  if (isis_circuit_up(circuit) != ISIS_OK) {
>  isis_circuit_deconfigure(circuit, area);
>  break;
>  }
>  circuit->state = C_STATE_UP;
>  isis_event_circuit_state_change(circuit, circuit->area,
>  1);

Do not return isis_link_params_update() if circuit->state != C_STATE_UP.

Fixes: 0fdd8b2b11 ("isisd: update link params after circuit is up")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
(cherry picked from commit 6ce6b7a8564f661495fec17f3ea33eeaf9e2f48c)
isisd/isis_te.c