]> git.puffer.fish Git - matthieu/frr.git/commit
zebra: Double check is not necessary in nexthop_active_update
authorDonald Sharp <sharpd@cumulusnetworks.com>
Tue, 16 Apr 2019 13:07:12 +0000 (09:07 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Thu, 18 Apr 2019 18:57:54 +0000 (14:57 -0400)
commit80ad04184f2e0b20bf8d0eff8fdd94fc1fb690da
tree5eac706ebd649dab6566d27026cbbee72ff35ae1
parentdd50eeb11501268003148b4d445be882db12823d
zebra: Double check is not necessary in nexthop_active_update

The nexthop_active_update command looks at each individual
nexthop and decides if it has changed.  If any nexthop
has changed we will set the re->status to ROUTE_ENTRY_CHANGED
and ROUTE_ENTRY_NEXTHOPS_CHANGED.

Additionally the test for old_nh_num != curr_active
makes no sense because suppose we have several events
we are processing at the same time and a total ecmp
of 16 but 14 are active at the start and 14 are active
at the end but different interfaces are up or down.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
zebra/zebra_rib.c