]> git.puffer.fish Git - matthieu/frr.git/commit
lib: another attempt at Coverity false positives
authorDavid Lamparter <equinox@opensourcerouting.org>
Thu, 14 Sep 2023 09:43:56 +0000 (11:43 +0200)
committerDavid Lamparter <equinox@opensourcerouting.org>
Thu, 14 Sep 2023 09:46:50 +0000 (11:46 +0200)
commit71510e531d8874f35d15460eb4c8a99d3ef31869
tree7627cc083fa3f6767712dcf129db4b2b3a9432b9
parent75dbd45c5570c088dc0e2cf83e1b22b0ec0a30b3
lib: another attempt at Coverity false positives

Typesafe hash tables do this:

assume((tabshift) >= 2 && (tabshift) <= 33);
(val) >> (33 - (tabshift));

Sadly, Coverity currently ignores assume() and says:
[...] right shifting by more than 31 bits has undefined behavior.
The shift amount, "33 - h->hh.tabshift", is 33.

Let's see if Coverity understands this can't happen...

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
lib/compiler.h