]> git.puffer.fish Git - matthieu/frr.git/commit
Revert "ripngd: Cleanup memory allocations on shutdown"
authorIgor Ryzhov <iryzhov@nfware.com>
Thu, 15 Jun 2023 14:42:05 +0000 (17:42 +0300)
committerMergify <37929162+mergify[bot]@users.noreply.github.com>
Tue, 20 Jun 2023 14:41:34 +0000 (14:41 +0000)
commit6527233f29ee6ba9b26d631332d50cf4964f8ffa
tree5e4110d128fff88be8180111a2ee308cf1111809
parent56a51f7edd1a0698bf51de7e195c12e374a4ca47
Revert "ripngd: Cleanup memory allocations on shutdown"

This reverts commit b1d29673ca16e558aea5d632da181555c83980cf.

This commit introduced a crash. When the VRF is deleted, the RIPNG
instance should not be freed, because the NB infrastructure still stores
the pointer to it. The instance should be deleted only when it's actually
deleted from the configuration.

To reproduce the crash:
```
frr# conf t
frr(config)# vrf vrf1
frr(config-vrf)# exit
frr(config)# router ripng vrf vrf1
frr(config-router)# exit
frr(config)# no vrf vrf1
frr(config)# no router ripng vrf vrf1
vtysh: error reading from ripngd: Resource temporarily unavailable (11)Warning: closing connection to ripngd because of an I/O error!
frr(config)#
```

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
(cherry picked from commit 9f6dade90e5e4686f67ae17b42c2873ec7ca6532)
ripngd/ripngd.c