]> git.puffer.fish Git - mirror/frr.git/commit
bgpd: Send End-of-RIB not only if Graceful Restart capability is received 16127/head
authorDonatas Abraitis <donatas@opensourcerouting.org>
Fri, 31 May 2024 12:03:55 +0000 (15:03 +0300)
committerDonatas Abraitis <donatas@opensourcerouting.org>
Fri, 31 May 2024 12:03:55 +0000 (15:03 +0300)
commit637ab53f75a9288888dfb48b8b939833fa3501ed
treeab3d231de67e7c19e918ada17e78bb1c93bde763
parent8e7bc85b713984aecd52c62d33ac8f53e813b7e6
bgpd: Send End-of-RIB not only if Graceful Restart capability is received

Before we checked for received Graceful Restart capability, but that was also
incorrect, because we SHOULD HAVE checked it per AFI/SAFI instead.

https://datatracker.ietf.org/doc/html/rfc4724 says:

Although the End-of-RIB marker is specified for the purpose of BGP
   graceful restart, it is noted that the generation of such a marker
   upon completion of the initial update would be useful for routing
   convergence in general, and thus the practice is recommended.

Thus, it might be reasonable to send EoR regardless of whether the Graceful Restart
capability is received or not from the peer.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
bgpd/bgp_packet.c