]> git.puffer.fish Git - mirror/frr.git/commit
bgpd: Add a better breadcrumb for when bgp is missconfiged 5836/head
authorDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 19 Feb 2020 15:52:14 +0000 (10:52 -0500)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 19 Feb 2020 15:52:14 +0000 (10:52 -0500)
commit3dbe2b6061ba07711584a87b714e76da92c4f8fa
tree5976c7c28a57c378d50f7aab4e1f19a9e27d420c
parent1a21da6b01ff50ac99eb6d54e6e1b2877ce5d5f8
bgpd: Add a better breadcrumb for when bgp is missconfiged

Currently During bgp open collision resolution if both
the router-id's are the same, we correctly follow
the RFC and close the connection.  The problem is of course
that there is no notification of the error in configuration
to the end user other than a subtle open debug message.

Explicitly call out the miss-configuration as an error message
as that this miss-config took several hours of debugging to notice.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd/bgp_errors.c
bgpd/bgp_errors.h
bgpd/bgp_packet.c