]> git.puffer.fish Git - mirror/frr.git/commit
tests: fix pytest API "surprise" in skipping tests
authorDavid Lamparter <equinox@opensourcerouting.org>
Tue, 11 Jul 2017 12:53:31 +0000 (14:53 +0200)
committerDavid Lamparter <equinox@opensourcerouting.org>
Tue, 11 Jul 2017 13:00:26 +0000 (15:00 +0200)
commit2e8a2df1fbd4c1d7ee7035dff6484ec5d093c5f1
tree454aa528f45f4fb15b82e22efbc786824b942469
parent49dd8e3758979254e74b8bf3480ea8a607f084b8
tests: fix pytest API "surprise" in skipping tests

pytest.mark.skipif apparently iterates through a class's methods,
applying itself onto the various methods.  Now, since we're deriving
from a parent class, the method is actually the same object inherited
from the parent, so the decorator will apply itself on the parent's
testrunning method (test_refout).  The result is that any TestRefout
tests after "test_commands.py" will be skipped...

This only became apparent after adding ospf6d/test_lsdb.py;  before,
test_commands.py was the last test in the list so it didn't matter...

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
tests/lib/cli/test_commands.py