]> git.puffer.fish Git - mirror/frr.git/commit
Zebra: Eliminate unnecessary del-add upon static route addition
authorvivek <vivek@cumulusnetworks.com>
Tue, 8 Dec 2015 23:04:48 +0000 (15:04 -0800)
committervivek <vivek@cumulusnetworks.com>
Tue, 8 Dec 2015 23:04:48 +0000 (15:04 -0800)
commit2bf26d4184cd6b6fdea42629725cd2005f8bef47
treec72fe049206d60922ac770e4d339e927e96cae72
parentcc81cf68da6ab43769112b50cb7faf3d6b333674
Zebra: Eliminate unnecessary del-add upon static route addition

When static routes are added, they get processed and potentially installed
in the RIB once. Subsequently, NHT is invoked and ends up scheduling the
route for processing again because this is the first time the nexthop is
resolved for NHT. This used to result in a del-add earlier (as noted in
the defect), but is a replace now. This change eliminates the unnecessary
replace by ensuring NHT is invoked first if the static route has a nexthop
that will be tracked by NHT.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Dinesh Dutt <ddutt@cumulusnetworks.com>
Ticket: CM-4573
Reviewed By: CCR-3903
Testing Done: Manual and bgpsmoke

Note: Updates/improves static route NHT patch(es).
zebra/zebra_rib.c