]> git.puffer.fish Git - mirror/frr.git/commit
ldpd: fix sporadic failures in the ldp-topo1 topotest 7878/head
authorRenato Westphal <renato@opensourcerouting.org>
Fri, 15 Jan 2021 15:04:24 +0000 (12:04 -0300)
committerRenato Westphal <renato@opensourcerouting.org>
Fri, 15 Jan 2021 20:44:46 +0000 (17:44 -0300)
commit1fd7ae7268f6aeb8c52b7d470c98a8b3fc41765e
tree45e84001c7bb4f33cdb041df6be72b8be14886cd
parentea8885d54e0ea29068f1b6df575e4cae5f7a89e1
ldpd: fix sporadic failures in the ldp-topo1 topotest

Commit 220e848cc5 introduced an optimization that would prevent ldpd
from sending redundant label mappings when it receives notifications
from zebra about routes that didn't effectively change (such
notifications can happen under certain circumstances).

The problem is that that commit didn't take into account the metric
of the received routes, so it would dismiss a notification of a
route with a better metric taking the place of another route in the
RIB, preventing the newly selected route from receiving the label
mappings it needs.

Revert 220e848cc5 temporarily to fix sporadic failures in the CI
system until we have a better solution.

Debugged-by: Lynne Morrison lynne@voltanet.io
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
ldpd/lde.h
ldpd/lde_lib.c