]> git.puffer.fish Git - mirror/frr.git/commit
build: fix `AM_LDFLAGS` usage (and gcov)
authorDavid Lamparter <equinox@opensourcerouting.org>
Wed, 21 Jul 2021 09:04:23 +0000 (11:04 +0200)
committermergify-bot <noreply@mergify.io>
Fri, 23 Jul 2021 09:32:49 +0000 (09:32 +0000)
commit1e0c986956b431c1d87e96182b2c457d2a636860
tree70270904309d700f74878e2d36e074c6e5a885c0
parent381752f3679b43f53f5c72e91153729853930a3f
build: fix `AM_LDFLAGS` usage (and gcov)

like the other automake variables, setting `xyz_LDFLAGS` causes
`AM_LDFLAGS` to be ignored for `xyz`.  For some reason I had in my mind
that automake doesn't do this for LDFLAGS, but... it does.  (Which is
consistent with `_CFLAGS` and co.)

So, all the libraries and modules have been ignoring `AM_LDFLAGS` (which
includes `SAN_FLAGS` too).  Set up new `LIB_LDFLAGS` and
`MODULE_LDFLAGS` to handle all of this correctly (and move these bits to
a central location.)

Fixes: #9034
Fixes: 0c4285d77eb ("build: properly split CFLAGS from AC_CFLAGS")
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
(cherry picked from commit 63116a7008706988136785ffa011cefee0355193)
16 files changed:
Makefile.am
bgpd/subdir.am
configure.ac
fpm/subdir.am
grpc/subdir.am
isisd/subdir.am
ldpd/subdir.am
lib/subdir.am
mlag/subdir.am
ospf6d/subdir.am
ospfclient/subdir.am
ospfd/subdir.am
pathd/subdir.am
qpb/subdir.am
ripd/subdir.am
zebra/subdir.am