]> git.puffer.fish Git - mirror/frr.git/commit
tests: fix sporadic failures in the ldp_topo1 topotest 11407/head
authorRenato Westphal <renato@opensourcerouting.org>
Mon, 13 Jun 2022 18:49:45 +0000 (15:49 -0300)
committerRenato Westphal <renato@opensourcerouting.org>
Tue, 14 Jun 2022 15:21:30 +0000 (12:21 -0300)
commit1c333cbed925dce20e94084226510278c2f56929
treee9b9bed56443e4ce56837bb416b5aa2b58d36212
parentfaa8c700e61ddbdb278c12787785df4eeecb23ff
tests: fix sporadic failures in the ldp_topo1 topotest

The sporadic failures were happening because, under heavy load,
the r4 router could form an OSPF adjacency with r3 a few seconds
before doing the same with r2. In that interim, LDP could establish
a neighborship with r2 going through r3 (instead of connecting
directly). That would cause all label mappings received from r3
to be ignored since they can't be mapped to the routes' nexthops
received from zebra, causing all sorts of test failures. None of
this is erroneous behavior as LDP simply follows the IGP.

The fix consists of updating the test to ensure all expected OSPF
adjacencies fully converged before proceeding to the LDP checks.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
tests/topotests/ldp_topo1/r1/show_ip_ospf_neighbor.json [new file with mode: 0644]
tests/topotests/ldp_topo1/r2/show_ip_ospf_neighbor.json [new file with mode: 0644]
tests/topotests/ldp_topo1/r3/show_ip_ospf_neighbor.json [new file with mode: 0644]
tests/topotests/ldp_topo1/r4/show_ip_ospf_neighbor.json [new file with mode: 0644]
tests/topotests/ldp_topo1/test_ldp_topo1.py