]> git.puffer.fish Git - matthieu/frr.git/commit
ospf: suppress delete using replacement
authorAyan Banerjee <ayan@cumulusnetworks.com>
Mon, 3 Dec 2012 18:48:46 +0000 (10:48 -0800)
committerScott Feldman <sfeldma@cumulusnetworks.com>
Mon, 7 Jan 2013 17:59:40 +0000 (09:59 -0800)
commit16a86b3e2f82d3e19a722e2ab34c2c77f62ed926
tree7c0826c1f684292ec80f8b7898e07f9c8e56b3f1
parente1a555b67cc868f95ea2b53c278bd8d091333e5f
ospf: suppress delete using replacement

After a SPF run, OSPF deletes routes that have changed in terms of any
metric, type, and/or next-hops and re-adds them. Given that the Zebra-RIB
already support replacement semantics, we suppress deletes for routes
that will be added back again.

This has the following advantages. It reduces the number of IPC messages
between OSPF/Zebra. Also, in the current flow, a batch of route deletes
were followed by a batch of adds even for say a metric change.

With the change, routes are sent as "add" when they are modified. Zebra
already implicitly deletes older routes.

Signed-off-by: Ayan Banerjee <ayan@cumulusnetworks.com>
Reviewed-by: Scott Feldman <sfeldma@cumulusnetworks.com>
Reviewed-by: Dinesh Dutt <ddutt@cumulusnetworks.com>
Signed-off-by: Scott Feldman <sfeldma@cumulusnetworks.com>
ospfd/ospf_route.c