]> git.puffer.fish Git - mirror/frr.git/commit
tests: use BUILT_SOURCES in tests/Makefile.am for automake 1.16.1 2408/head
authorArthur Jones <arthur.jones@riverbed.com>
Mon, 11 Jun 2018 21:55:50 +0000 (14:55 -0700)
committerArthur Jones <arthur.jones@riverbed.com>
Tue, 12 Jun 2018 15:05:00 +0000 (08:05 -0700)
commit15ecc92750bc9b5c51e469bf4380420e67d7740e
tree9d5a822b18e944a2f30e96307581c4b2643d9ca8
parent2a4269ccd8f96cd2ab8c0ef9e33e3878ff0eed94
tests: use BUILT_SOURCES in tests/Makefile.am for automake 1.16.1

When trying to run make check using automake 1.16.1, we get:

CC isisd/test_fuzz_isis_tlv-test_fuzz_isis_tlv.o
isisd/test_fuzz_isis_tlv.c:1:10: fatal error: test_fuzz_isis_tlv_tests.h: No such file or directory
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Makefile:1096: recipe for target 'isisd/test_fuzz_isis_tlv-test_fuzz_isis_tlv.o' failed
make[1]: *** [isisd/test_fuzz_isis_tlv-test_fuzz_isis_tlv.o] Error 1
make[1]: Leaving directory '/src/frr-frr-5.0/tests'
Makefile:1220: recipe for target 'check-am' failed
make: *** [check-am] Error 2

From reading the automake docs, it looks like there may be a more
reliable way to express built files in the Makefile.am using BUILT_SOURCES.
Using this method, we seem to build fine now on 1.16.1 and this
has been tested on Ubuntu 18.04, CentOS 7 and Alpine edge (which uses
automake 1.16.1).

Issue: https://github.com/FRRouting/frr/issues/2403
Signed-off-by: Arthur Jones <arthur.jones@riverbed.com>
tests/Makefile.am