]> git.puffer.fish Git - matthieu/frr.git/commit
lib: Prevent crash after shutdown request
authorDonald Sharp <sharpd@nvidia.com>
Tue, 19 Apr 2022 18:48:29 +0000 (14:48 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Tue, 19 Apr 2022 18:55:55 +0000 (14:55 -0400)
commit10258b031a1fbcd7f7a2cb6108af2402bbef2b43
tree3fb57a9cf5ad14260d2411558615ae6f8f9a2e4c
parent16b5065b47d38d0464e81d5302445da8fbaf8fe3
lib: Prevent crash after shutdown request

Recent commit e92508a741e03b8721ccb3424cbebe4d5476e9d changed
the prefix_master->str to a RB tree.  This introduced a condition
whnere on shutdown the prefix list was removed from the master list
and then operated on by passing around a name.  Which was then used
to lookup the prefix list again when we operated on the code.
This change to a RB Tree first deleted the item from the RB tree
first thus introducing this crash

Crash:
(gdb) bt
    index=0x556c07d59650, pentry=0x556c07d29380) at lib/routemap.c:2397
    arg=0x7ffdbf84bc60) at lib/hash.c:267
    event=RMAP_EVENT_PLIST_DELETED) at lib/routemap.c:2489

Grab the first item on the list, clean it and then remove it.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
lib/plist.c