]> git.puffer.fish Git - matthieu/frr.git/commit
BGP: Do not get out of bgp_start() if peer's IP address isn't known
authorvivek <vivek@cumulusnetworks.com>
Wed, 21 Oct 2015 05:01:49 +0000 (22:01 -0700)
committervivek <vivek@cumulusnetworks.com>
Wed, 21 Oct 2015 05:01:49 +0000 (22:01 -0700)
commit085567f9553966f0042cd2f7cda0551a84f63b2f
treeb794db46e1ea30242ed57d45d18b881e25784d9c
parentc41fc67b25b8832697c676dc66493043e76c1d45
BGP: Do not get out of bgp_start() if peer's IP address isn't known

Ticket: CM-7140
Reviewed By: CCR-3412
Testing Done: bgpsmoke, Atul verified fix

BGP Unnumbered and Interface based peering can interact in some strange
ways. One of them is when there's an IPv4 address on a link on which
BGP Unnumbered session is beng attempted, but the IPv4 address is not
a /30 or /31. As per the bug report, we end up attempting to start the
BGP FSM on receiving a notification that an IPv4 address is present on
an interface. To avoid attempting to go past BGP's start state in the
absence of a valid peer address is the right thing to do. And this
simple patch does just that.

Signed-off-by: Dinesh G Dutt <ddutt@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Vipin Kumar <vipin@cumulusnetworks.com>
bgpd/bgp_fsm.c